(Created page with "<!-- page was renamed from HowToReviewPackages --> '''Author:''' Tom 'spot' Callaway and others<BR> '''Revision:''' 0.06<BR> '''Initial Draft:''' 2007-03-12<BR>...")
(11 intermediate revisions by one other user not shown)
Line 1:
Line 1:
<!-- page was renamed from HowToReviewPackages
-->
'''Author:''' [[TomCallaway| Tom 'spot' Callaway]] and others<BR>
'''Revision:''' 0.06<BR>
'''Initial Draft:''' 2007-03-12<BR>
'''Last Revised:''' 2010-11-13<BR>
{{autolang}}
{{autolang}}
{{Anchor|ReviewProcess}}
{{Anchor|ReviewProcess}}
== Review Purpose ==
In order for a new package to be added to Fedora, the package must first undertake a formal review. The purpose of this formal review is to try to ensure that the package meets the quality control requirements for Fedora. This does not mean that the package (or the software being packaged) is perfect, but it should meet baseline minimum requirements for quality.
Reviews are currently done for totally new packages, [[Package_Renaming_Process#Re-review_required|package renames]], and packages merged from the old Fedora Core repository.
There are two roles in the review process, that of the contributor and that of the reviewer. In this document, we'll present both perspectives.
审核过程有两种角色，贡献人员 和 审核者。本文档将会详细说明这两者。
=== Contributor ===
=== 贡献人员 ===
A Contributor is defined as someone who wants to submit (and maintain) a new package in Fedora. To become a contributor, you must follow the detailed instructions to [[Join the package collection maintainers]].
贡献人员就是想要提交新软件包的人，又可以称之为提交者。如果想要成为一名贡献人员，您必须按照 [[Join the package collection maintainers/zh-cn|成为 Fedora 软件包仓库维护人员]] 的步骤来做。
As a Contributor, you should have already made a package which adheres to the [[Packaging:NamingGuidelines| Package Naming Guidelines]] and [[Packaging:Guidelines| Packaging Guidelines]]. There are also some packages that cannot be included in Fedora, to check if your package applies, check if it contains any [[Forbidden items]].
<li> Fill out a [https://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&format=fedora-review request for review in bugzilla]. For guidance, a [[:Image:PackageReviewProcess_review.png|screenshot of a sample bugzilla request is available for review]].
<li> If you do not have any package already in Fedora, this means you need a sponsor and to add FE-NEEDSPONSOR to the bugs being blocked by your review request. For more information read the [[How to get sponsored into the packager group]] wiki page.
<li> 如果您尚未在 Fedora 中维护任何软件包，您需要标记您的审核请求的 Blocks 为 FE-NEEDSPONSOR（177841）并由您的保证人提供保证。详情请阅读 [[How to get sponsored into the packager group]]。
<li> Wait for someone to review your package! At this point in the process, the '''fedora-review flag''' is blank, meaning that no reviewer is assigned.
{{admon/tip|Review Swaps| If nobody comments on your review request, you might want to mail to a mailing list ([https://admin.fedoraproject.org/mailman/listinfo/devel devel@lists.fedoraproject.org], for example) asking for a "review swap". This is an offer to do a review of someone else's package in exchange for them reviewing your package. This is usually one-for-one, or can be some other private arrangement depending on the difficulty of the respective packages. }}
<li> There may be comments from people that are not formally reviewing the package, they may add NotReady to the Whiteboard field, indication that the review request is not yet ready, because of some issues they report. After you have addressed them, please post the URLs to the updated SPEC and SRPM file and remove it from the Whiteboard. It is expected that you will respond to commentary, including updating your submission to address it; if you do not, your ticket will be closed.
<li> The reviewer will review your package. You should fix any blockers that the reviewer identifies. Once the reviewer is happy with the package, the '''fedora-review''' flag will be set to '''+''', indicating that the package has passed review.
<li> You should make sure the review ticket is closed. You are welcome to close it once the package has been built on the requested branches, or if you built for one of the Fedora release branches you can ask Bodhi to close the ticket for you when it completes the process. If you close the ticket yourself, use '''NEXTRELEASE''' as the resolution.
You do not need to go through the review process again for subsequent package changes.
后期的软件包变动不再需要执行该审核流程，并且不应在 Bodhi 中创建的后续更新中引用审核凭证。
=== 审核者 ===
=== Reviewer ===
审核者就是审核软件包的人。
The Reviewer is the person who chooses to review a package.
{{admon/note|fedora-review 工具|
fedora-review 是一个十分有用的自动化审核工具。只需要 <code>dnf install fedora-review</code> 然后阅读 man 手册了解用法即可。注意，这并不意味着全部，您仍然需要透彻了解[[Packaging:Guidelines|打包规定]]。}}
{{admon/note|Comments by other people|
{{admon/note|其他人的意见|
Other people are encouraged to comment on the review request as well. Especially people searching for sponsorship should comment other review requests to show, that they know the [[Packaging:Guidelines|Packaging Guidelines]].
The Reviewer can be any Fedora account holder, who is a member of the [https://admin.fedoraproject.org/accounts/group/members/packager/* packager group]. There is one exception: If it is the first package of a Contributor, the Reviewer must be a [https://admin.fedoraproject.org/accounts/group/members/packager/*/sponsor Sponsor]. You can check if a Contributor has already been sponsored by looking the e-mail address up in the [https://admin.fedoraproject.org/accounts/group/members/packager/* packager group of the account system].
<li> Search for a review request that needs a reviewer: http://fedoraproject.org/PackageReviewStatus/ ('''fedora-review flag''' is blank or the bug is assigned to nobody@fedoraproject.org)
<li> If you notice some issues that need to be solved before you want to start a formal review, add these issues in a comment and set the Whiteboard of the bug to contain NotReady. This helps other possible reviewers to notice that the review request is not yet ready for further review action.
{{admon/note|Stepping back from a Review|If you want to step back from the review for any reason, reset the <code>fedora-review</code> flag to be blank '''and''' reassign the bug to the default owner of the component, which is '''nobody@fedoraproject.org'''}}
{{admon/question|Time to sponsor?|If the Reviewer is also acting as Sponsor for the Contributor, then this is the time to sponsor the Contributor in the [https://admin.fedoraproject.org/accounts/ account system]}}
{{admon/question|Time to sponsor?|如果审核者想要成为贡献者的赞助者，则可以在 [https://admin.fedoraproject.org/accounts/ 账户系统] 中赞助贡献者}}
<li> '''FAIL, LEGAL''' - If the package is legally risky for whatever reason (known patent or copyright infringement, trademark concerns) close the bug WONTFIX and leave an appropriate comment (i.e. we don't ship mp3, so stop submitting it). Set the '''fedora-review''' flag to '''-''', and have the review ticket block FE-Legal.
<li> '''FAIL, OTHER''' - If the package is just way off or unsuitable for some other reason, and there is no simple fix, then close the bug WONTFIX and leave an appropriate comment (i.e. we don't package pornography for redistribution, sorry. Or, this isn't a specfile, it's a McDonald's menu, sorry.) Set the '''fedora-review''' flag to '''-'''.
<li> '''NEEDSWORK''' - Anything that isn't explicitly failed should be left open while the submitter and reviewer work together to fix any potential issues. Mark the bug as NEEDINFO while waiting for the reviewer to respond to improvement requests; this makes it easier for reviewers to find open reviews which require their input.
<li> Once a package is flagged as '''fedora-review +''' (or '''-'''), the Reviewer's job is done although they may be called upon to assist the Contributor with the import/build/update process and to sure that the Contributor closes the ticket out when the process is complete.
|fedora-review||-||Package Failed Review, dropped for legal or other issues.
|fedora-review||-||由于法律或其它问题，审核失败
|-
|-
|fedora-review||+||Package Approved
|fedora-review||+||审核通过
|}
|}
== Special blocker tickets ==
== 特殊的 blocker 支持单 ==
There are a few tickets which can be placed in the "Blocks" field to indicate specific ticket statuses:
少量支持单会设置 "Blocks" 字段，以表明特殊的状态：
{| border="1"
{| border="1"
|-
|-
|FE-NEEDSPONSOR||The submitter requires a sponsor; the review should only be done by a sponsor.
|FE-NEEDSPONSOR||审核提交人需要保证人。注意审核过程只能有一位担保人。
|-
|-
|FE-DEADREVIEW||The review has been closed out because the submitter has left; users looking for packages to submit may find some possibilities in these dead tickets.
|FE-Legal||The package is currently awaiting review by the legal team.
|FE-Legal||该软件包被社区法律团队认定存在法律风险。
|}
|}
== The Whiteboard ==
== 白板 (Whiteboard) ==
To save time for reviewers, the page at http://fedoraproject.org/PackageReviewStatus/NEW.html will hide certain tickets which are not reviewable. The Whiteboard field can be used to mark a ticket with various additional bits of status which will cause it to be hidden or displayed differently.
|NotReady||The package is not yet ready for review. It is possible to open a review ticket, mark it as NotReady, and continue to work on it until it's ready to be seen by a reviewer.
* [https://bugzilla.redhat.com/bugzilla/buglist.cgi?product=Fedora&component=Package+Review&bug_status=NEW,ASSIGNED,NEEDINFO,MODIFIED&field0-0-0=flagtypes.name&type0-0-0=notsubstring&value0-0-0=fedora-review New Review Requests] ([http://fedoraproject.org/PackageReviewStatus/NEW.html Cached for faster access])
* [https://bugzilla.redhat.com/bugzilla/buglist.cgi?product=Fedora&component=Package+Review&bug_status=NEW,ASSIGNED,NEEDINFO,MODIFIED&field0-0-0=flagtypes.name&type0-0-0=equals&value0-0-0=fedora-review%3F Packages Currently Under Review] ([http://fedoraproject.org/PackageReviewStatus/REVIEW.html Cached for faster access])
* [https://bugzilla.redhat.com/buglist.cgi?query_format=advanced&field0-0-0=flagtypes.name&bug_status=NEW&bug_status=ASSIGNED&bug_status=MODIFIED&type0-0-0=equals&value0-0-0=fedora-review%2B&component=Package%20Review&product=Fedora Packages Reviewed but not Closed]
Review Swaps
退出审核
Time to sponsor?
