|
|
| Line 1: |
Line 1: |
| = ReviewOMatic = | | = ReviewOMatic = |
|
| |
|
| * Home Page https://fedorahosted.org/review-o-matic/wiki
| |
| * Browse Source Code https://fedorahosted.org/review-o-matic/browser
| |
| * Mailing List https://fedorahosted.org/mailman/listinfo/review-o-matic
| |
|
| |
| Review-o-matic is an infrastructure feature. Aim is making an application which gets up as a service and can also be set up locally.
| |
|
| |
|
|
| |
|
| == Summary == | | == Summary == |
|
| |
|
| The aim of the project includes the creation of a application that would review the packages as per the Package Review Guidelines and generate a report. It will also include automating all common steps which every reviewer performs for each review and building guideline checks for all Package guidelines which can be automated.
| |
|
| |
|
| == Owner == | | == Owner == |
| Line 20: |
Line 14: |
| * Percentage of completion: 15% | | * Percentage of completion: 15% |
|
| |
|
| == Detailed Description ==
| | DeviceKit, DeviceKit-disks, DeviceKit-power and gnome-disk-utility packages have been built |
| | in rawhide. |
|
| |
|
| Review-o-matic would be an application which takes a spec or srpm or just rpms through its feeder and does a review and posts its report via its reporter interface. Feeder will have different interfaces to get input e.g bugzilla, local host m/c (as files) or web interface or service. Reports will also be provided to different interfaces depending upon needs e.g Bugzilla, local m/c (as file) or web service. Our process also includes(very much obviously) running rpmlint on input files. We plan to push all guidelines checks to upstream rpmlint. But there are some hybrid checks which:
| | gnome-power-manager 2.25.1 in rawhide uses DeviceKit-power instead of hal. |
|
| |
|
| * are fedora specific
| | == Detailed Description == |
| * require input from logs generated via builders or multiple file inspection and are very much out of scope of rpmlint
| |
| | |
| will need to be kept in review-o-matic.
| |
|
| |
|
| ([https://fedorahosted.org/review-o-matic/wiki/Check_Table Check table]) is were inspecting each checks one by one and decide on which are programmable and which are not, takes place.
| |
|
| |
| Plan is to speed up automating guidelines once structural architecture get working with very basic capabilities and later on concentrate on automating guidelines.
| |
|
| |
| Structural Architecture of whole design for now is:
| |
|
| |
| {{Anchor|process-flow}}
| |
| [[Image:Rom1.png]]
| |
|
| |
| Source: https://fedoraproject.org/wiki/Image:Rom1.dia
| |
|
| |
| ----
| |
|
| |
|
| == Benefit to Fedora == | | == Benefit to Fedora == |
|
| |
| * Automatically building srpms once they are submitted for package review and responding depending upon the result of build.
| |
| * Running rpmlint and other automated guideline checks provided by review-o-matic and providing a report.
| |
| * Periodically checking already existing packages in repository for their consistency with guidelines and proving reports to maintainers. There by doing a periodic maintenance for ever increasing fedora packages.
| |
|
| |
|
| == Scope == | | == Scope == |
|
| |
|
| Requires completing the structural design and writing checks or guideline programs for those packaging guidelines which can be automated.
| |
|
| |
|
| == How To Test == | | == How To Test == |
|
| |
| To be discussed.
| |
|
| |
|
| == User Experience == | | == User Experience == |
|
| |
| * Application can be initiated locally, via Bugzilla, via web service.
| |
| * Developers/Maintainers input files (spec, srpm, rpm) to be reviewed.
| |
| * Generates reports and presents via Bugzilla, web service or output file.
| |
|
| |
|
| == Dependencies == | | == Dependencies == |
|
| |
|
| * rpmlint
| |
| * rpm-python
| |
| * python-bugzilla
| |
| * koji
| |
|
| |
|
| == Contingency Plan == | | == Contingency Plan == |
|
| |
|
| Not needed.
| |
|
| |
|
| == Documentation == | | == Documentation == |
|
| |
|
| Right now wiki has some bare minimum documentation:
| |
| https://fedorahosted.org/review-o-matic/wiki
| |
|
| |
|
| == Release Notes == | | == Release Notes == |
