(change %{__sed} to sed) |
mNo edit summary |
||
Line 16: | Line 16: | ||
or dos2unix. | or dos2unix. | ||
</pre> | </pre> | ||
Here also <code>%{__sed}</code> changed to simply <code>sed</ | Here also <code>%{__sed}</code> changed to simply <code>sed</code> to be consistent with other parts of guidelines. | ||
But the problem could still be in EPEL4, so a note should be added to guidelines specific to it: <br /> | But the problem could still be in EPEL4, so a note should be added to guidelines specific to it: <br /> |
Revision as of 07:13, 5 June 2009
Proposal to explicitly allow dos2unix
In guidelines in common errors section https://fedoraproject.org/wiki/Packaging/Guidelines#Rpmlint_Errors there is the following phrase:
This error occurs because of DOS line breaks in a file. Fix it with sed in the %prep section: %{__sed} -i 's/\r//' src/somefile -- DONT use dos2unix, that can cause build fail on FC3.
Because FC3 is not supported for long time, I'm proposing to change it to:
This error occurs because of DOS line breaks in a file. Fix it in the %prep section with sed: <code>sed -i 's/\r//' src/somefile</code> or dos2unix.
Here also %{__sed}
changed to simply sed
to be consistent with other parts of guidelines.
But the problem could still be in EPEL4, so a note should be added to guidelines specific to it:
https://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL4
* Don’t use dos2unix under EPEL4, as it could fail.