User talk:Valce

Proposed changes to ld

Basics

The default behaviour for ld currently defaults to not linking objects that are listed as dependencies of another linked object. This is dangerous if the other object is ever changed to occlude the object on which your program depended, causing your program to break without any change to your code.

What's the difference?

For example (courtesy Roland McGrath):

 ==> foo1.c <==
 #include <stdio.h>
 extern int foo ();
 int
 main ()
 {
   printf ("%d\n", foo ());
 }

 ==> foo2.c <==
 extern int foo ();
 int bar () { return foo (); }

 ==> foo3.c <==
 int foo () { return 0; }

gcc -g -fPIC -c foo1.c foo2.c foo3.c

gcc -shared -o foo3.so foo3.o

gcc -shared -o foo2.so foo2.o foo3.so

(This Succeeds)

gcc -o foo1 foo1.o foo2.so -Wl,--rpath-link=.

(This Fails)

gcc -Wl,--no-add-needed -o foo1 foo1.o foo2.so -Wl,--rpath-link=.

/usr/bin/ld: �: invalid DSO for symbol foo' definition

./foo3.so: could not read symbols: Bad value

collect2: ld returned 1 exit status

[Exit 1]


What it meant to say was:

gcc -Wl,--no-add-needed -o foo1 foo1.o foo2.so -Wl,--rpath-link=. -B/tmp/

/tmp/ld: ./foo3.so: invalid DSO for symbol foo' definition

./foo3.so: could not read symbols: Bad value

collect2: ld returned 1 exit status

[Exit 1]

So, the difference is whether you can refer to a symbol that's in a DSO that you didn't list explicitly in your link line, but that is a DT_NEEDED dependency of one of those (or recursively of those, I think).

I find that error message not very explanatory, but it's what it says. Giving a generic "undefined symbol" error (which usually comes with source line info for the reference) would be less strange but also perhaps too generic for this specially weird case.

New result:

gcc -o foo1 foo1.o foo2.so -Wl,--rpath-link=.

/usr/bin/ld: foo1.o: undefined reference to symbol 'foo'

/usr/bin/ld: note: 'foo' is defined in DSO ./foo3.so so try adding it to the linker command line

The big difference is that with the proposed change in place, ld will no longer skip linking needed libraries by default. The current default behaviour will lead ld to skip linking with a library if it is listed as a needed by another library that the program uses. In abstract terms, if libA is needed by libB and your program requires both libA and libB, your program may only link to libB. Then if another version of libB comes out that does not list libA as a needed library, then a recompilation will mysteriously break.

A concrete example from Roland McGrath:

libxml2.so has:

 NEEDED            Shared library: [libdl.so.2]
 NEEDED            Shared library: [libz.so.1]

In this case, a program that links with libxml2 and uses dlopen may not link with libdl, and a program that links with libxml2 and uses gzopen may not link with libz. While these programs will work, they are at risk of failure if libxml2 is ever changed to omit the dependency on libdl/libz.

What do I do?

The error message will prompt you to explicitly link to the DSO that you need. From the foo exmaple, adding foo3.so will get rid of the error:

gcc -o foo1 foo1.o foo2.so foo3.so -Wl,--rpath-link=.

Testing eclipse-cdt on F-12

Setup

1. Use fedora-cvs eclipse-cdt to grab a copy of the CDT from fedora's CVS
2. In the F-12 folder, cat eclipse-cdt.spec | grep define\ build_id and note the build_id (e.g. v200906161748)
3. In an Eclipse install, open up the CVS repository and paste :pserver:anonymous@dev.eclipse.org:/cvsroot/tools into the location
4. Under HEAD, go to org.eclipse.cdt, go into the all folder and right click the packages there. Select Checkout As, then click Next until you get to the final screen. In the Tag box, type the build id. This will start searching for the tag, select it and click Finish

Testing

org.eclipse.cdt.core.tests

1. suite --> AutomatedIntegrationSuite: 3698 | 0 | 0
2. parser --> ParserTestSuite: 2259 | 0 | 0
3. org.eclipse.cdt.core.parser.tests.prefix --> CompletionTestSuite: 5 | 0 | 0
4. org.eclipse.cdt.core.parser.tests.rewrite.astwriter --> AstWriterTestSuite: 331 | 0 | 0
5. org.eclipse.cdt.core.parser.tests.rewrite.commenthandler --> CommentHandlerTestSuite 123 | 0 | 0
6. org.eclipse.cdt.core.parser.tests.scanner --> CommentHandlerTestSuite 261 | 0 | 0
7. org.eclipse.cdt.internal.index.tests --> All clear
8. org.eclipse.cdt.internal.pdom.tests --> All clear
9. model --> org.eclipse.cdt.core.language --> AllLanguageTests 6 | 0 | 0
10. org.eclipse.cdt.core.model.tests --> AllCoreTests 123 | 0 | 0
11. org.eclipse.cdt.core.model.tests --> AllLanguageTests 39 | 0 | 0
12. org.eclipse.cdt.core.settings.models --> AllCProjectDescriptionTests 21 | 0 | 0

The following tests have failures, but they fluctuate

1. org.eclipse.cdt.core.parser.tests.rewrite.changegenerator --> ChangeGeneratorTestSuite: 43 | 0 | 16
2. org.eclipse.cdt.core.parser.tests.rewrite.changegenerator.append --> TestSuite: 9 | 0 | 1
3. org.eclipse.cdt.core.parser.tests.rewrite.changegenerator.insertbefore --> InsertBeforeTestSuite 8 | 0 | 3
4. org.eclipse.cdt.core.parser.tests.rewrite.changegenerator.remove --> RemoveTestSuite 13 | 0 | 4
5. org.eclipse.cdt.core.parser.tests.rewrite.changegenerator.replace --> ReplaceTestSuite 13 | 0 | 5

Number of failures varies -- tests pass if you run them directly, but fail otherwise.

org.eclipse.cdt.debug.ui.tests

1. org.eclipse.cdt.debug.testplugin.util --> ExpectedStringsTests: 4 | 0 | 0
2. org.eclipse.cdt.debug.core.tests --> AllDebugTests 12 | 0 | 0

org.eclipse.cdt.make.core.tests

1. org.eclipse.cdt.make.builder.tests --> both tests pass
2. org.eclipse.cdt.make.core.tests --> AutomatedIntegrationSuite 25 | 0 | 1