Line 62: | Line 62: | ||
This change will add new macros which will make it easier for packages to add and remove their own compiler flags. This strategy is already used to some extent with feature macros like %{_lto_cflags}, %{_hardening_cflags}, etc, but these new flags will give packagers more fine-grained control over the options. | This change will add new macros which will make it easier for packages to add and remove their own compiler flags. This strategy is already used to some extent with feature macros like %{_lto_cflags}, %{_hardening_cflags}, etc, but these new flags will give packagers more fine-grained control over the options. | ||
The proposed new macros are: | The proposed new macros macros for adding new flags are: | ||
%_package_extra_cflags %{nil} | %_package_extra_cflags %{nil} | ||
Line 69: | Line 69: | ||
%_package_extra_ldflags %{nil} | %_package_extra_ldflags %{nil} | ||
These will be added to %{build_cflags}, %{build_cxxflags}, %{build_fflags}, %{build_ldflags} to allow packges to add their own flags to the default | These will be added to %{build_cflags}, %{build_cxxflags}, %{build_fflags}, and %{build_ldflags} respectively to allow packges to add their own flags to the default list: e.g. | ||
%build_cflags %{optflags} %{_package_extra_cflags} | |||
The proposed new macros to represent existing flags are: | |||
== Feedback == | == Feedback == |
Revision as of 22:27, 31 May 2022
RPM Macros for Build Flags
Summary
Create a corresponding macro for each compiler flag in the redhat-rpm-config macro file and create "extra flag" macros to make it easier for packages to control the set of default flags.
Owner
- Name: Tom Stellard
- Email: <tstellar@redhat.com>
Current status
- Targeted release: Fedora Linux 37
- Last updated: 2022-05-31
- FESCo issue: <will be assigned by the Wrangler>
- Tracker bug: <will be assigned by the Wrangler>
- Release notes tracker: <will be assigned by the Wrangler>
Detailed Description
Detailed Description
The macros file in the redhat-rpm-config package contains a list of default compiler flags for packages to use when compiling C,C++, and Fortran packages. There is currently no standard way to remove or add to the set of default flags. Most packages use a combination of echo and sed to remove unwanted flags or add new ones. Some examples:
ghdl: OPT_FLAGS=echo %{optflags}|sed -e 's/\(-Wp,\)\?-D_FORTIFY_SOURCE=[12]//g'
julia: %global optflags %(echo %{optflags} | sed 's/-Wp,-D_GLIBCXX_ASSERTIONS //')
compiler-rt: global optflags %(echo %{optflags} -D_DEFAULT_SOURCE)
This change will add new macros which will make it easier for packages to add and remove their own compiler flags. This strategy is already used to some extent with feature macros like %{_lto_cflags}, %{_hardening_cflags}, etc, but these new flags will give packagers more fine-grained control over the options.
The proposed new macros macros for adding new flags are:
%_package_extra_cflags %{nil} %_package_extra_cxxflags %{nil} %_package_extra_fflags %{nil} %_package_extra_ldflags %{nil}
These will be added to %{build_cflags}, %{build_cxxflags}, %{build_fflags}, and %{build_ldflags} respectively to allow packges to add their own flags to the default list: e.g.
%build_cflags %{optflags} %{_package_extra_cflags}
The proposed new macros to represent existing flags are:
Feedback
Benefit to Fedora
Scope
- Proposal owners:
- Other developers:
- Release engineering: #Releng issue number
- Policies and guidelines: N/A (not needed for this Change)
- Trademark approval: N/A (not needed for this Change)
- Alignment with Objectives:
Upgrade/compatibility impact
How To Test
User Experience
Dependencies
Contingency Plan
- Contingency mechanism: (What to do? Who will do it?) N/A (not a System Wide Change)
- Contingency deadline: N/A (not a System Wide Change)
- Blocks release? N/A (not a System Wide Change), Yes/No
Documentation
N/A (not a System Wide Change)