The page source contains comments providing guidance to fill out each section. They are invisible when viewing this page. To read it, choose the "view source" link.
Copy the source to a new page before making changes! DO NOT EDIT THIS TEMPLATE FOR YOUR CHANGE PROPOSAL.
For details on how to fill out this form, see the documentation.
Remove make from BuildRoot
Summary
This change will remove make from the default buildroot in Koji and mock.
Owner
- Name: Tom Stellard
- Email: <tstellar@redhat.com>
Current status
- Targeted release: Fedora 34
- Last updated: 2020-10-27
- FESCo issue: <will be assigned by the Wrangler>
- Tracker bug: <will be assigned by the Wrangler>
- Release notes tracker: <will be assigned by the Wrangler>
Detailed Description
Phase 1: Analysis
For this change, we will start by creating a list of all packages that have a build-time dependency on make. This will be done by analyzing spec files and also by rebuilding all packages in Fedora with make removed from the buildroot to see which packages fail to build. Once we have this list, we will remove packages that already have BuildRequires:make in their spec file, and this final list[1] will be all the packages that need to be updated in Phase 2.
[1] https://github.com/tstellar/fedora-change-make-buildroot/blob/main/needs_br_make.txt
Phase 2: Package Updates
Once we have the list of packages that need to be updated, we will proceed with adding BuildRequires: make to all spec files that require it. This new BuildRequires will be added to the line after the last BuildRequires: in the spec file. Also, the release number for packages will *not* be incremented for this change.
The spec file updates will be automated and changes will be pushed directly to dist-git once they are ready.
Phase 3: Update Buildroot
Once package spec files have been updated, then we can proceed with removing make from the BuildRoot. This will be done by removing make from the build group in Koji and by remvoing make from the buildsys-build group in comps (fedora-comps).
Phase 4: Monitor Failures
Once all the changes are in place, we will continue to monitor koji builds to see if there are any failures related to this change. We expect that the analysis done in Phase 1 would give us the complete list of packages that need to be updated, but it is always possible that something will be missed.
Feedback
Benefit to Fedora
Based on my research[1], Fedora has 22309 packages, and there are approximately 10414 packages that either use make explicitly or fail to build when make is removed form the buildroot. This means that there are around 11895 packages that don't need make. Removing make from the BuildRoot will reduce the network traffic, download times, and disk usage for these builds in Koji and also for users doing builds with mock.
Removing make (and its dependencies) will:
- Reduce the BuildRoot download size by: 7.3 MB [2]:
- make: 539k
- gc: 104k
- guile22: 6.6M
- libtool-ltdl: 36k
- Reduce the BuildRoot install size by; 46 MB [2]:
- make: 1.6M
- gc: 229k
- guile22: 44M
- libtool-ltdl: 71k
[1] https://github.com/tstellar/fedora-change-make-buildroot
[2] Package sizes are from the x86_64 packages.
Scope
- Proposal owners: Tom Stellard
- Other developers: Fedora package maintainers should report bugs if they think there is a problem caused by this change, but otherwise there will be no action required by them.
- Proven Packager: The proposal owner will need to either apply for provenpackager status or get the help of someone with provenpackager status in order to make the spec file changes that are required.
- Fedora Infrastructure Team: Someone on the Fedora infrastructure team will need to remove make from the buildroot once all the changes are ready.
- Release engineering: #Releng issue number (a check of an impact with Release Engineering is needed)
- Policies and guidelines: N/A (not a System Wide Change)
The packager guidelines will need to be updated to mention that BuildRequires: make is now required for all packages that need make.
- Trademark approval: N/A (not needed for this Change)
- Alignment with Objectives: This aligns with the Fedora Minimization objective.
Upgrade/compatibility impact
N/A (not a System Wide Change)
How To Test
N/A (not a System Wide Change)
User Experience
Dependencies
N/A (not a System Wide Change)
Contingency Plan
- Contingency mechanism: (What to do? Who will do it?) N/A (not a System Wide Change)
- Contingency deadline: N/A (not a System Wide Change)
- Blocks release? N/A (not a System Wide Change), Yes/No
- Blocks product? product
Documentation
N/A (not a System Wide Change)